-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scIB vignette #14
Conversation
The vignette now shows how to recreate the scIB summary figure. The result is pretty close but not exactly the same. The big difference is that the bars are coloured by score rather than rank, which makes them appear quite different. Also for some reasons the legends don't show (I'm probably missing something but not sure what). Other small things I couldn't work out how to do (let me know if there is a solution):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Luke! This PR is fantastic, thank you so much for creating it!
I created a few suggestions to make the code less wordy. Are these ok for you? This is the result of the vignette with suggestions included: https://rcannood.quarto.pub/recreating-the-scib-figures.
Regarding the remaining discrepancies:
- Colouring by rank: This is something that I'm working on allowing with the changes proposed in Feature request: Option for size and color represent two column value of a circle #9
- Legends don't show, add a palette to a text column: WIP in the refactor_legends branch
- Control over column label rendering: Should be tackled in a separate issue
- Remove the dotted lines around bars: Should also be tackled in a separate issue
Let me know if the proposed suggestions are okay with you.
Various suggestions from review to make things more readable and tidy up the plot a bit. Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
Thanks for the suggestions, I think those have improved things!
Do you want me to open issues for these? |
Yes please! |
This PR will add a vignette showing how to recreate the figures from the scIB paper