Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scIB vignette #14

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Add scIB vignette #14

merged 7 commits into from
Jul 14, 2023

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented May 31, 2023

This PR will add a vignette showing how to recreate the figures from the scIB paper

@lazappi
Copy link
Contributor Author

lazappi commented Jul 12, 2023

The vignette now shows how to recreate the scIB summary figure. The result is pretty close but not exactly the same. The big difference is that the bars are coloured by score rather than rank, which makes them appear quite different. Also for some reasons the legends don't show (I'm probably missing something but not sure what).

Other small things I couldn't work out how to do (let me know if there is a solution):

  • Align the column labels
  • Move the column labels to the bottom
  • Adjust the size/other styling of text columns/labels
  • Add a palette to a text column
  • Remove the dotted lines around bars

Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Luke! This PR is fantastic, thank you so much for creating it!

I created a few suggestions to make the code less wordy. Are these ok for you? This is the result of the vignette with suggestions included: https://rcannood.quarto.pub/recreating-the-scib-figures.

Regarding the remaining discrepancies:

Let me know if the proposed suggestions are okay with you.

vignettes/scIB.Rmd Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
vignettes/scIB.Rmd Outdated Show resolved Hide resolved
lazappi and others added 2 commits July 14, 2023 09:48
Various suggestions from review to make things more readable and tidy up the plot a bit.

Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
@lazappi
Copy link
Contributor Author

lazappi commented Jul 14, 2023

Thanks for the suggestions, I think those have improved things!

  • Control over column label rendering: Should be tackled in a separate issue
  • Remove the dotted lines around bars: Should also be tackled in a separate issue

Do you want me to open issues for these?

@rcannood
Copy link
Collaborator

  • Control over column label rendering: Should be tackled in a separate issue
  • Remove the dotted lines around bars: Should also be tackled in a separate issue

Do you want me to open issues for these?

Yes please!

@rcannood rcannood marked this pull request as ready for review July 14, 2023 08:36
@rcannood rcannood merged commit ab668f6 into funkyheatmap:main Jul 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants