Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase exception message when unable to combine branches #12

Open
hampusboesenfunnel opened this issue Apr 8, 2022 · 0 comments
Open

Comments

@hampusboesenfunnel
Copy link

If the function main._combine_branches fails to combine branches, it raises a ValueError with this message:

Multiple branches dont know how to handle these, either

I think this message can be improved to better communicate the context in which the problem arises.

Suggestions

  • Include the selected method in the message
  • Include the branches that couldn't be processed in the message (this can potentially be quite long, but if at least the point(s) of branching can be communicated I think it would be quite helpful)
  • I don't quite understand what the "either" means in the context of this exception—maybe it can be rephrased or omitted?

What do you think about something like this?

Unable to combine branches with the selected method:
    method: None
    branches: {'a': {'A': 123}, 'b':[{'c':1},{'c':2}]}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant