Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove comment from generated noop makefile #5

Merged
merged 1 commit into from Dec 23, 2014

Conversation

jsvd
Copy link
Contributor

@jsvd jsvd commented Dec 22, 2014

Installing this gem on a win7 machine using mingw fails because the generated noop Makefile has a comment that is executed:

C:\jruby-1.7.17\lib\ruby\gems\shared\gems\murmurhash3-0.1.4\ext\murmurhash3>make

#nothing to build
process_begin: CreateProcess(NULL, #nothing to build, ...) failed.
make (e=2): The system cannot find the file specified.
make: Interrupt/Exception caught (code = 0xc0000005, addr = 0x000007FEFF7D2020)

Removing this like fixed it for me.

funny-falcon added a commit that referenced this pull request Dec 23, 2014
remove comment from generated noop makefile
@funny-falcon funny-falcon merged commit 55afac5 into funny-falcon:master Dec 23, 2014
@jsvd
Copy link
Contributor Author

jsvd commented Dec 23, 2014

@funny-falcon thank you for the quick merge, are you planning to do a release anytime soon?

@jsvd jsvd deleted the fix_windows_mingw_install branch December 23, 2014 14:52
@funny-falcon
Copy link
Owner

v0.1.5

@funny-falcon
Copy link
Owner

As I understand, you need it for jruby ?

@jsvd
Copy link
Contributor Author

jsvd commented Dec 23, 2014

@funny-falcon yes a couple of logstash plugins use this gem on jruby, and on windows they weren't working. but now they do :) thank you very much!

@funny-falcon
Copy link
Owner

I'll try to release jruby version tomorrow

@funny-falcon
Copy link
Owner

I just pushed native jruby gem (v0.1.6). Can you tell if it is good or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants