Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model structure precludes addresses with no localities/states #15

Open
furious-luke opened this issue Jan 2, 2015 · 8 comments
Open

Comments

@furious-luke
Copy link
Owner

It occurs to me that some addresses may not have a state or locality (actually, I'm not sure this is true). It might be necessary to allow address without one or both of these. This will require a bit of a look at the model structure.

@LennyLip
Copy link

may be models must support xAL format?

@furious-luke
Copy link
Owner Author

That looks interesting, thanks!

@LennyLip
Copy link

another approach is create sql schema from xal.xsd (for example, using Altova XMLSpy) and run django inspectdb to create models from DB.

I'm trying to do it now

@furious-luke
Copy link
Owner Author

The latest version of django-address, 0.2 (still on the dev branch) will no longer be troubled by this issue. The code now constructs dynamic hierarchies of address components based on Google's results from geocoding.

@jplehmann
Copy link

We just spent 1 week migrating off the dev branch, only to find that this issue exists on master, and apparently has never been addressed.

Copenhagen, Denmark is an example.

This issue needs to be re-opened. @banagale

@banagale banagale reopened this Nov 4, 2021
@banagale
Copy link
Collaborator

banagale commented Nov 4, 2021

Sorry to hear that, John, that has to be frustrating.

I've re-opened it. Do you have a test available for this failing behavior by any chance?

@jplehmann
Copy link

Rob thanks for the quick response.

I don't have a unit test, but I have a test case... as mentioned "Copenhagen, Denmark".

We haven't thought about this that much, but our plans at the moment are:

  1. First try to hack the Javascript so that the input always includes at least "UNKNOWN" as a state. This sounds like it might just work.
  2. If that doesn't work and/or later, to create a patch for the lib which supports unknown states by creating an "unknown" entity.

Open to other ideas too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants