Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to nullsafety #15

Merged
merged 4 commits into from
Dec 31, 2021
Merged

Conversation

andersonfds
Copy link

@andersonfds andersonfds commented Nov 30, 2021

Motivation

This plugin is beautiful! It deserves to be updated to the nowadays standards.

Description

  • Added support to nullsafety
  • Changed dart minimum version to 2.12
  • Changed example project to nullsafety too
  • Edited the changelog

Checks

  • Did you test your feature?
  • Did it worked both on Android and iOS?

@furkantektas
Copy link
Owner

Hi Anderson 👋🏻,
Thank you very much, this is quite an improvement and maintenance for the repo. All the changes seems good to me, please give me some time as I still need to merge another PR which I couldn't merge for quite a long time. I'll sort this out as soon as I can.
Thanks

@andersonfds
Copy link
Author

Hi Anderson 👋🏻, Thank you very much, this is quite an improvement and maintenance for the repo. All the changes seems good to me, please give me some time as I still need to merge another PR which I couldn't merge for quite a long time. I'll sort this out as soon as I can. Thanks

Sure, no problem. If there is any merge conflicts with the other pull requests, just let me know and I'll fix

@furkantektas
Copy link
Owner

I really appreciate it, thank you very much

@furkantektas furkantektas merged commit f372cc6 into furkantektas:master Dec 31, 2021
@furkantektas
Copy link
Owner

Hi @andersonfds ,
I have merged #9 today and resolved the conflicts with this PR afterwards. I wish I wrote some tests for this library, but, unfortunately, I didn't. That's why, I did a quick test with the example application, seems like it doesn't break anything.
I will bump the version 0.1.0 with your contribution.
Thank you very much for your time and effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants