Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies typings according to new pattern #66

Merged
merged 1 commit into from Apr 1, 2016

Conversation

thitemple
Copy link

Hey guys, I'm sorry for creating a new PR for the same issue #34 .

Today I checked with the guys from the project https://github.com/typings/registry, when I tried to registry this project in their list of typings and according to them, because the project is hosting the typings there's a better way to do that.

Which is by adding the typings property on the package.json file and that required me to make some changes on the typings definition.

I've tested on my local project and this is working.

Also, because the typings are on the project and registered on the package.json file there's no need for an external tool to install the typings.

Again, I'm sorry for creating a second PR

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.59% when pulling 3480ff4 on vintem:develop into d8bc4ee on furqanZafar:develop.

@furqanZafar furqanZafar merged commit de635be into furqanZafar:develop Apr 1, 2016
@furqanZafar
Copy link
Owner

Thanks for the PR, good job 👍 , been super busy lately, hope it wasn't too difficult to figure out the types

@thitemple
Copy link
Author

Actually, it was very easy. I followed the API documentation for that.

@atifsyedali
Copy link

Just wondering...Why was this merged on to develop and not master?

@ghost
Copy link

ghost commented Jan 18, 2017

Following up from @atifsyedali's comment - has this been pushed to master?

@ehartford
Copy link

ehartford commented Jan 26, 2017

plz @furqanZafar
added a PR for this
#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants