Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage for test_actors #107

Merged
merged 8 commits into from
Sep 21, 2019

Conversation

skoudoro
Copy link
Contributor

This PR just adds some more global tests and fix some pep8.

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #107 into master will increase coverage by 1.7%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #107     +/-   ##
=========================================
+ Coverage   86.15%   87.86%   +1.7%     
=========================================
  Files          14       14             
  Lines        3851     3847      -4     
  Branches      474      471      -3     
=========================================
+ Hits         3318     3380     +62     
+ Misses        397      351     -46     
+ Partials      136      116     -20
Impacted Files Coverage Δ
fury/actor.py 94.44% <100%> (+7.84%) ⬆️
fury/optpkg.py 80% <100%> (-2.86%) ⬇️
fury/ui.py 85.11% <100%> (ø) ⬆️

@pep8speaks
Copy link

pep8speaks commented Sep 16, 2019

Hello @skoudoro! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-16 19:01:11 UTC

@skoudoro skoudoro changed the title [WIP] Adding some tests Increase coverage for test_actors Sep 16, 2019
@Garyfallidis
Copy link
Contributor

Good job. Thanks!

@Garyfallidis Garyfallidis merged commit fbcdcc2 into fury-gl:master Sep 21, 2019
@skoudoro skoudoro deleted the increase-coverage branch September 21, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants