Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Change examples README file extension to markdown #142

Conversation

jhlegarreta
Copy link
Contributor

Change examples README file extension to markdown.

Change examples `README` file extension to markdown.
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          17       17           
  Lines        4145     4145           
  Branches      514      514           
=======================================
  Hits         3645     3645           
  Misses        363      363           
  Partials      137      137

@skoudoro
Copy link
Contributor

skoudoro commented Feb 4, 2020

Hi @jhlegarreta,

Did you check if sphinx-gallery is happy with this change? Did you try to generate the documentation? Thank you for your feedback

@jhlegarreta
Copy link
Contributor Author

I have not @skoudoro . The equivalent file in DIPY is also a Markdown file, and in the Sphinx gallery transition PR they are reSructuredText files.

May be the Azure CI pipelines could be taught to build the documentation to test such changes?

@skoudoro
Copy link
Contributor

skoudoro commented Feb 4, 2020

The doc generation is already on Travis. There is no problem during the compilation but I do not know if it is visually correct. There are often many surprises and a visual check is always necessary.

I would love to see people starting to have this habit to generate the documentation on their own laptop to check if everything is ok visually since the generation takes only 30sec (at the opposite of DIPY 😄)

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see here on Travis, documentation generation is failing. Can you have a look to see why @jhlegarreta?
Thanks

@jhlegarreta
Copy link
Contributor Author

Thanks @skoudoro ! Following your note I tried to build the docs locally and got the same error, so I will close this PR and open a new one transitioning to reSructuredText.

@jhlegarreta jhlegarreta closed this Feb 4, 2020
@jhlegarreta jhlegarreta deleted the ChangeExamplesREADMEFileExtensionToMarkdown branch February 4, 2020 19:08
@skoudoro skoudoro added this to the v0.5.0 milestone Feb 4, 2020
@jhlegarreta
Copy link
Contributor Author

PR #144 proposes the transition to reStructuredText.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants