Animated Network Visualization Example #167
Conversation
|
Hello @filipinascimento! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-03-03 18:17:46 UTC |
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
========================================
+ Coverage 87.93% 88% +0.06%
========================================
Files 17 17
Lines 4145 4219 +74
Branches 514 527 +13
========================================
+ Hits 3645 3713 +68
- Misses 363 367 +4
- Partials 137 139 +2
|
There was a problem hiding this comment.
Thank you for this PR @filipinascimento! Really cool tutorial!
I know it is work in progress, but I added some quick comments below to fix. Thanks!
| # Shaders Trick | ||
|
|
||
|
|
||
| mapper = lines_actor.GetMapper() |
There was a problem hiding this comment.
You can remove this line and the title above (Shader Trick)
| # Run every 200 milliseconds | ||
| showm.add_timer_callback(True, 16, timer_callback) | ||
|
|
||
| showm.start() |
There was a problem hiding this comment.
Can you replace this line by
interactive = False
if interactive:
showm.start()
window.record(showm.scene, size=(900, 768), out_path="viz_animated_networks.png")|
|
||
| ############################################################################### | ||
| # This example can be improved by adding some interactivy with slider, | ||
| # picking, etc. Play with it, improve it! |
There was a problem hiding this comment.
Can you remove this comment block
| lines_actor = actor.line(np.zeros((len(edges), 2, 3)), | ||
| colors=edges_colors, lod=False) | ||
| lines_actor.GetProperty().SetRenderLinesAsTubes(1) | ||
| lines_actor.GetProperty().SetLineWidth(5) | ||
| lines_actor.GetProperty().SetOpacity(1) |
There was a problem hiding this comment.
This can be done in one line like:
lines_actor = actor.line(np.zeros((len(edges), 2, 3)), colors=edges_colors, lod=False, linewidth=5, fake_tube=True)There was a problem hiding this comment.
Nice, good catch @dmreagan!
There was a problem hiding this comment.
Thanks, but I remember we discussed that their behavior are different. If I'm not mistaken, one uses fury implementation of fake tubes and the other uses vtk implementation. The shaders are different. Anyway I will check this again and make the other proposed changes.
There was a problem hiding this comment.
Oh they are the same. Thanks. will make the change.
skoudoro
changed the title
| ############################################################################### | ||
| # Lets create our edges now. They will indicate a citation between two nodes. | ||
| # OF course, the colors of each edges will be an interpolation between the two | ||
| # node that it connects. |
| radii=radii*0.5, | ||
| theta=8, | ||
| phi=8, | ||
| ) |
There was a problem hiding this comment.
remove comma and push parenthesis up
| x1, y1, z1 = pos[vertex1] | ||
| x2, y2, z2 = pos[vertex2] | ||
| distance = math.sqrt( | ||
| (x2-x1)*(x2-x1) + |
| rz = (z2-z1)/distance | ||
| Fx = -b*rx/distance/distance | ||
| Fy = -b*ry/distance/distance | ||
| Fz = -b*rz/distance/distance |
There was a problem hiding this comment.
pep8 issues from line 156 to line 164
| x1, y1, z1 = pos[vFrom] | ||
| x2, y2, z2 = pos[vTo] | ||
| distance = math.sqrt( | ||
| (x2-x1)*(x2-x1) + |
- Removes unused variables
skoudoro
changed the title
|
Thank you @filipinascimento ! |
This is a work in progress demo for animated network visualization.
Two modes are implemented, one in which the positions of nodes are defined by a force-directed layout algorithm; and another with the positions of the network being progressively displaced by random increments.