Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Layout for RangeSlider #204

Merged
merged 5 commits into from
Mar 16, 2020

Conversation

Nibba2018
Copy link
Member

Overview

  • Adding a vertical layout for RangeSlider.

Example:

range-slider-2020-03-14-194607

Code Snippet for the above viz:

from fury import ui, window

range_slider_hor = ui.RangeSlider(
    line_width=8, handle_side=25, range_slider_center=(200, 500),
    value_slider_center=(200, 400), length=250, min_value=0,
    max_value=10, font_size=18, range_precision=2, value_precision=4,
    shape="square")
    
range_slider_ver = ui.RangeSlider(
    line_width=8, handle_side=25, range_slider_center=(475, 450),
    value_slider_center=(375, 450), length=250, min_value=0,
    max_value=10, font_size=18, range_precision=2, value_precision=4,
    orientation="vertical", shape="square")
    
current_size = (800, 800)
show_manager = window.ShowManager(size=current_size, title="Range Sliders Example")
show_manager.scene.add(range_slider_hor)
show_manager.scene.add(range_slider_ver)
show_manager.start()

@pep8speaks
Copy link

pep8speaks commented Mar 14, 2020

Hello @Nibba2018! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-03-14 15:01:13 UTC

@Nibba2018 Nibba2018 changed the title Added vertical Layout for RangeSlider Vertical Layout for RangeSlider Mar 14, 2020
@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@85a0cc8). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #204   +/-   ##
=========================================
  Coverage          ?   88.61%           
=========================================
  Files             ?       17           
  Lines             ?     4340           
  Branches          ?      545           
=========================================
  Hits              ?     3846           
  Misses            ?      354           
  Partials          ?      140           
Impacted Files Coverage Δ
fury/ui.py 86.24% <100.00%> (ø)
fury/utils.py 89.54% <0.00%> (ø)
fury/convert.py 73.33% <0.00%> (ø)
fury/testing.py 89.28% <0.00%> (ø)
fury/layout.py 71.05% <0.00%> (ø)
fury/decorators.py 100.00% <0.00%> (ø)
fury/interactor.py 96.39% <0.00%> (ø)
fury/transform.py 100.00% <0.00%> (ø)
fury/optpkg.py 80.00% <0.00%> (ø)
... and 8 more

@skoudoro skoudoro added this to the v0.5.0 milestone Mar 14, 2020
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Thank you @Nibba2018!

LGTM, but I need to run it locally to be sure. I will let you know if I see something wrong.

@Nibba2018
Copy link
Member Author

@skoudoro sure take your time 👍

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works as expected. I will merge this PR tomorrow, after #190. Thank you @Nibba2018!

@skoudoro skoudoro merged commit a80b05a into fury-gl:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants