-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical Layout for RangeSlider #204
Conversation
Hello @Nibba2018! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-14 15:01:13 UTC |
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=========================================
Coverage ? 88.61%
=========================================
Files ? 17
Lines ? 4340
Branches ? 545
=========================================
Hits ? 3846
Misses ? 354
Partials ? 140
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, Thank you @Nibba2018!
LGTM, but I need to run it locally to be sure. I will let you know if I see something wrong.
@skoudoro sure take your time 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, it works as expected. I will merge this PR tomorrow, after #190. Thank you @Nibba2018!
Overview
RangeSlider
.Example:
Code Snippet for the above viz: