Octagonal Prism and Frustum Square Pyramid

[mlraglin]

Added two new primitive shapes: the octagonal prism and the frustum square pyramid, to primitive.py and actor.py. Also added tests for both new shapes in test_primitive.py and test_actor.py.

[pep8speaks]

Hello @mlraglin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-12 17:11:16 UTC

[skoudoro]

Hi @mlraglin,

Thank you for these new features! Can you address pep8 errors when you have time? Furthermore, test_vertices_primitives_octagonalprism does not pass. Can you run and check it on your environment to see what's going on?

I'm tagging @lenixlobo and @Nibba2018 to review your PR after your update.

Thank you !

[codecov]

Codecov Report

Merging #249 into master will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   88.69%   88.55%   -0.15%     
==========================================
  Files          17       17              
  Lines        4387     4446      +59     
  Branches      553      569      +16     
==========================================
+ Hits         3891     3937      +46     
- Misses        356      366      +10     
- Partials      140      143       +3     

Impacted Files	Coverage Δ
fury/actor.py	93.12% <100.00%> (+0.36%)	⬆️
fury/primitive.py	87.06% <100.00%> (+1.35%)	⬆️
fury/utils.py	86.79% <0.00%> (-3.24%)	⬇️
fury/ui.py	86.13% <0.00%> (-0.16%)	⬇️
fury/data/__init__.py	100.00% <0.00%> (ø)
fury/interactor.py	96.92% <0.00%> (+0.53%)	⬆️

[skoudoro]

Thank you for the update @mlraglin.

I will wait for @lenixlobo and @Nibba2018 last review before merging this PR.

[lenixlobo]

Great job!
Looks good to me!

[skoudoro]

Thank you @mlraglin! Merging