Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implementation of Text Overflow in ListBox2D #264

Closed
2 tasks done
Nibba2018 opened this issue Jul 14, 2020 · 3 comments · Fixed by #268
Closed
2 tasks done

Re-implementation of Text Overflow in ListBox2D #264

Nibba2018 opened this issue Jul 14, 2020 · 3 comments · Fixed by #268
Labels
state: needs PR type:Bug Fix Something isn't working
Milestone

Comments

@Nibba2018
Copy link
Member

Nibba2018 commented Jul 14, 2020

Description

Due to the newer implementation of TextBlock2D and its size property in #248 , the Text Overflow bug fix previously implemented in #173 isn't relevant anymore and therefore needs to be re-implemented. #173 was a workaround for the incorrect size calculation given by TextBlock2D.size, but the current implementation provides the correct value.

Way to reproduce

  • Code example
from fury import ui, window
values = ["Violet", "Indigo", "Blue", "Green", "Yellow", "Orange", "Red"]
listBox = ui.ListBox2D(values, position=(70, 40), size=(250, 150))
sm = window.ShowManager(size=(400, 200))
sm.scene.add(listBox)
sm.start()
  • Relevant images (if any)
    Previously:
    image

Currently:
image

@skoudoro
Copy link
Contributor

Good catch! Are you working on it?

@skoudoro skoudoro added type:Bug Fix Something isn't working state: needs PR labels Jul 14, 2020
@skoudoro skoudoro added this to the v0.6.0 milestone Jul 14, 2020
@Nibba2018
Copy link
Member Author

@skoudoro Should I work on this or should I continue with ComboBox and Tab UI?

@skoudoro
Copy link
Contributor

  1. Combobox
  2. Fix this issue
  3. back to Tab UI

@skoudoro skoudoro linked a pull request Jul 19, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: needs PR type:Bug Fix Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants