Clip Text Overflow #268
Clip Text Overflow #268
Conversation
|
Hello @Nibba2018! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-07-19 19:53:26 UTC |
Nibba2018
added
🚀 🐍 GSOC 2020
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 89.07% 89.04% -0.03%
==========================================
Files 19 19
Lines 4750 4812 +62
Branches 619 629 +10
==========================================
+ Hits 4231 4285 +54
- Misses 363 366 +3
- Partials 156 161 +5
|
There was a problem hiding this comment.
Thank you for this @Nibba2018! Below, a first review but I need to test it. I will come back to you after some tests. Thank you again!
fury/utils.py
Outdated
| return original_str | ||
|
|
||
| else: | ||
| while start_ptr < end_ptr: |
There was a problem hiding this comment.
I wonder about the impact of this while for performance. clip_overflow seems to be called often. I need to test it. As a temporary solution, I will be fine but we will have to find a better approach.
There was a problem hiding this comment.
The complexity of this is around log2(length). The problem is each character has a different height and width.
Also the width of two characters within a string isn't equal to the sum of their individual widths.
|
Ok, it works as expected, no issue. Thank you @Nibba2018! I will wait that you move the function and it will be ready for merge |
|
@skoudoro , codecov patch seems to fail. Any Idea how I can fix that? |
There was a problem hiding this comment.
Thank you for fixing this issue @Nibba2018! there is a small pep8 but we will fix it later.I will go ahead and merge your PR.
skoudoro
added this to In progress
in [GSOC] Create new user interface widget
via automation
skoudoro
moved this from In progress
to Reviewer approved
in [GSOC] Create new user interface widget
fury.uito maintain abstraction. Users can use this method to clip theirTextBlock2Dtext for a given width.