Disable VTK Warnings on release version #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this block the warning window we see about deprecated shader functions? |
|
Yes @dmreagan |
|
Is this PR working for you @dmreagan ? |
|
Switching it on or off does remove the printed version. Both options do not show the warning window. Is this expected? |
|
Works on Windows 10 and Ubuntu. +1 on my side. |
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 88.84% 88.66% -0.18%
==========================================
Files 19 19
Lines 4974 4986 +12
Branches 645 648 +3
==========================================
+ Hits 4419 4421 +2
- Misses 390 399 +9
- Partials 165 166 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a utility function to switch ON or OFF the global warning window of VTK. By default, it is ON on the dev version and OFF for the release version.
fix #270.