Re-enable transparency test, change colors #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dmreagan! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 80.83% 81.03% +0.19%
==========================================
Files 12 12
Lines 3011 3011
Branches 333 333
==========================================
+ Hits 2434 2440 +6
+ Misses 475 470 -5
+ Partials 102 101 -1
|
|
Thank you @dmreagan! LGTM, I just need to test it on my mac and then, I can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #6, I found that
test_order_transparenthad been mostly commented out. When I un-commented it, one of the assertions failed. When the green line was in front, the test expected the pixel's green component to be larger than the red component. In reality, it was smaller by 1, despite the image looking correct. I changed the green line's color from [0, 0.5, 0] to [0, 1., 0] and now the tests pass, both in offscreen and onscreen rendering.