Cone actor uses repeat_primitive by default
#547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 88.58% 88.69% +0.10%
==========================================
Files 55 55
Lines 11003 11107 +104
Branches 1084 1092 +8
==========================================
+ Hits 9747 9851 +104
Misses 959 959
Partials 297 297
|
skoudoro
reviewed
Apr 13, 2022
fury/actor.py
Outdated
| @@ -1858,6 +1858,8 @@ def cone(centers, directions, colors, heights=1., resolution=10, | |||
| If faces is None then a cone is created based on directions, heights | |||
| and resolution. If not then a cone is created with the provided | |||
| vertices and faces. | |||
| use_primitive: boolean | |||
skoudoro
reviewed
Apr 13, 2022
fury/primitive.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| radius: float |
skoudoro
reviewed
Apr 13, 2022
fury/primitive.py
Outdated
| ---------- | ||
| radius: float | ||
| Radius of the cone | ||
| height: float |
skoudoro
reviewed
Apr 13, 2022
fury/primitive.py
Outdated
| Radius of the cone | ||
| height: float | ||
| Height of the cone | ||
| sectors: int |
skoudoro
reviewed
Apr 13, 2022
fury/primitive.py
Outdated
|
|
||
| """ | ||
|
|
||
| if not sectors > 2: |
There was a problem hiding this comment.
if sectors < 2: instead
There was a problem hiding this comment.
Thank you for the update. Unfortunately, tests are failing so I will check only after you fix the tests.
There was a problem hiding this comment.
Hi @skoudoro, I just figured out that advanced_geometry_test was failing due to the arrow_actor. changing the height parameter with scale fixes the size of arrows 😅 .
I changed the axes actor's repeat_primitive=False, window.snapshot wasn't detecting colors while using primitive arrows.
skoudoro
reviewed
Apr 14, 2022
| scene.add(cone_actor1) | ||
| scene.add(cone_actor2) | ||
|
|
||
| interactive = True |
| if interactive: | ||
| window.show(scene, size=(600, 600)) | ||
|
|
||
| window.record(scene, out_path='viz_markers.png', size=(600, 600)) |
There was a problem hiding this comment.
Wrote that by mistake, Modified to viz_cone.
fury/actor.py
Outdated
| colors=colors, active_scalars=heights, | ||
| source=src, vertices=vertices, faces=faces) | ||
| return cone_actor | ||
| else: |
|
Thank you @xtanion for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #529