Updates and corrections in slicer and ui #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nifti images with affines with flips and rotations
…rectly support without a need to map the values
|
Hello @Garyfallidis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-26 15:27:55 UTC |
Garyfallidis
changed the title
Garyfallidis
changed the title
|
Travis is happy, can you fix all pep8 and make Codacy happy too @Garyfallidis ? |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 84.97% 84.78% -0.19%
==========================================
Files 14 14
Lines 3766 3805 +39
Branches 460 466 +6
==========================================
+ Hits 3200 3226 +26
- Misses 435 447 +12
- Partials 131 132 +1
|
Garyfallidis
changed the title
|
Thank you @Garyfallidis for this update. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not really a slicer 4D (only branch name) it is just corrections on the existing slicer.