Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] add Python 3.8 #127

Merged
merged 6 commits into from Jul 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .mailmap
Expand Up @@ -19,6 +19,8 @@ Vivek Choudhary <choudhary.vivek98@gmail.com> Vivek <choudhary.vivek98@gmail.com
Saransh Jain <b18191@students.iitmandi.ac.in> Saransh <b18191@students.iitmandi.ac.in>
Saransh Jain <b18191@students.iitmandi.ac.in> Saransh Jain <48832748+Saransh0905@users.noreply.github.com>
ChenCheng0630 <chencheng991207@gmail.com> ccheng1 <ccheng1@paypal.com>
Javier Guaje <jrguajeg@iu.edu> Javier Guaje <guaje@users.noreply.github.com>
Javier Guaje <jrguajeg@gmail.com> Javier Guaje <jrguajeg@iu.edu>
Javier Guaje <jrguajeg@gmail.com> Javier Guaje <guaje@users.noreply.github.com>
Shreyas Bhujbal <shreyasb2@gmail.com> Shreyas Bhujbal <shreyasbhujbal@zoho.com>
Shreyas Bhujbal <shreyasb2@gmail.com> kakashihatakae <shreyasb2@gmail.com>
Shreyas Bhujbal <shreyasb2@gmail.com> kakashihatakae <shreyasb2@gmail.com>

1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -28,6 +28,7 @@ env:
python:
- 3.6
- 3.7
- 3.8

matrix:
include:
Expand Down
2 changes: 2 additions & 0 deletions azure-pipelines.yml
Expand Up @@ -22,6 +22,8 @@ jobs:
python.version: '3.7'
Python36-64bit:
python.version: '3.6'
Python38-64bit:
python.version: '3.8'
CONDA Python37-64bit + OPTIONAL_DEPS:
python.version: '3.7'
OPTIONAL_DEPS: true
Expand Down
4 changes: 2 additions & 2 deletions fury/tests/test_deprecator.py
Expand Up @@ -78,10 +78,10 @@ def test_deprecate_with_version():
def func_no_doc():
pass

def func_doc(i):
def func_doc(_i):
"A docstring"

def func_doc_long(i, j):
def func_doc_long(_i, _j):
"A docstring\n\n Some text"

class CustomError(Exception):
Expand Down
14 changes: 7 additions & 7 deletions fury/tests/test_pick.py
@@ -1,5 +1,6 @@
import numpy as np
from fury import actor, window, io, ui, pick
from fury import actor, window, ui, pick
from fury.testing import assert_greater
import numpy.testing as npt
import itertools

Expand Down Expand Up @@ -59,16 +60,15 @@ def timer_callback(_obj, _event):
showm.add_timer_callback(True, 200, timer_callback)
showm.start()

npt.assert_equal(np.sum(np.array(record_indices['vertex_indices'])) > 1,
True)
npt.assert_equal(np.sum(np.array(record_indices['face_indices'])) > 1,
True)
assert_greater(np.sum(np.array(record_indices['vertex_indices'])), 1)
assert_greater(np.sum(np.array(record_indices['face_indices'])), 1)

for ac in record_indices['actor']:
if ac is not None:
npt.assert_equal(ac is sphere_actor, True)

npt.assert_equal(np.sum(np.abs(np.diff(np.array(record_indices['xyz']),
axis=0))) > 0, True)
assert_greater(np.sum(np.abs(np.diff(np.array(record_indices['xyz']),
axis=0))), 0)


if __name__ == "__main__":
Expand Down
1 change: 0 additions & 1 deletion fury/ui.py
@@ -1,4 +1,3 @@
from _warnings import warn
from collections import OrderedDict

import numpy as np
Expand Down