Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tutorial for RadioButton and CheckBox UI #208
Added tutorial for RadioButton and CheckBox UI #208
Changes from all commits
e397a8c
913b47f
b7fced4
769b3c9
3426b8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need of this function, it is on the
fury.actor
module. Please, remove it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need of this function, it is on the
fury.actor
module. Please, remove it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove
cube_maker
,sphere_make
r,cone_maker
,arrow_make
r and replace them byactor.cone
,actor.cube
,actor.sphere
,actor.arrow
.you need to import
actor
module on the topThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool, I'll have a look at it.
But then why are we not using
actor.cube
in other tutorials as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because they are old and they need to be updated 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, I was looking at the
actor
earlier while coding the tutorials and was wondering why are we not incorporating this instead.In this case, I should update
viz_ui.py
andviz_ui_slider.py
as well, maybe in a separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skoudoro I'm unable to toggle colors of the figures when using
actor.cube
.I've checked the value of colors is being set using
cube.GetProperty().GetColor()
but it's not reflecting on the window.what could be the reason? maybe the actors which are returned are the reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it is much more complicated to update the colors. We need to create some functions/interfaces to make it easier. So, keep it as it is for the moment and just do the other corrections.
To get the color, you can use
cube.GetMapper().GetColorMapColors()
but it is not convenient to update it. It needs some thinking.Thank you @PaulNicolasHunter !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I understand @skoudoro, I'll try to dig more into it and find a workaround as soon as possible.