Standardize colors across API #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 88.90% 88.75% -0.16%
==========================================
Files 19 19
Lines 4959 4827 -132
Branches 644 630 -14
==========================================
- Hits 4409 4284 -125
+ Misses 385 382 -3
+ Partials 165 161 -4
|
skoudoro
force-pushed
the
normalize-colors
branch
from
fb63c2c
to
f1f0154
Compare
fury/utils.py
Outdated
| colors: (Nx3) ndarray | ||
| N is equal to the number of lines. Every line is coloured with a | ||
| different RGB color. | ||
| colors: (Mx3) or (Mx4) ndarray |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to standardize colors across the API [0 -1]
fix #271
fix #242
fix #243
supersede and fix #269
This PR should be merged after #282