BUG: Fix peaks_slicer actor properties not being enforced.
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as with #44, Travis errors come from the |
|
Nibabel team plans to fix this and @dmreagan will review your PR tomorrow so let's wait until Thursday for this PR. |
dmreagan
reviewed
Jan 9, 2019
The actor created in `peak_slicer` was not having its properties enforced because the `PeakSlicerActor` instance was not explicitly setting its `vtk::Property` properties. These properties were being set in the actor of the `self.line` object, but needed to be set for the `PeakSlicerActor` class itself. Fixes fury-gl#22.
jhlegarreta
force-pushed
the
FixPeakSlicerActorProperties
branch
from
b0f5ca9
to
cd005b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 81.05% 81.07% +0.01%
==========================================
Files 13 13
Lines 3062 3065 +3
Branches 349 349
==========================================
+ Hits 2482 2485 +3
Misses 476 476
Partials 104 104
|
|
@dmreagan May be I should have also modified the test and add some opacity values to less than 1.0 to actually proof that the patch is working? |
|
More tests, or more explicit tests, are usually a good idea. If you have time, go for it. But since this PR fixes an existing feature rather than adding something new, I'm not going to be strict about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actor created in
peak_slicerwas not having its propertiesenforced because the
PeakSlicerActorinstance was not explicitlysetting its
vtk::Propertyproperties. These properties were being setin the actor of the
self.lineobject, but needed to be set for thePeakSlicerActorclass itself.Fixes #22.