Added GSoC blog posts for remaining weeks #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 33 33
Lines 7093 7093
Branches 834 834
=======================================
Hits 6313 6313
Misses 547 547
Partials 233 233 |
skoudoro
reviewed
Sep 11, 2021
There was a problem hiding this comment.
Hi @antrikshmisri,
Overall, it looks good. Thank you for this. See below for some minor comments. could you also rebase. After those changes, it will be ready to go. Thanks!
| ------------------------ | ||
| Below are the tasks that I worked on: | ||
|
|
||
| * `Created PR for sprite sheet animation <https://github.com/fury-gl/fury/pull/491>`_ : This Pr adds support for playing animations from a sprite sheet. This feature will be used in Card2D to create a tutorial in which the card will show the animation in the image box. Previously, the utility functions for this were added directly inside the tutorial but now they are refactored to go in their respective modules. |
|
Hello @antrikshmisri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
skoudoro
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.