Added my first blog post #586

m-agour · 2022-05-23T19:48:29Z

No description provided.

skoudoro · 2022-05-23T22:57:05Z

Great! Thank you @m-agour for this first version. we will start the review of this PR on wednesday.

ganimtron-10

Hey @m-agour ,
Below are the few typos and punctuation issues I found out in your post.
PTAL.
Thanks!

ganimtron-10 · 2022-05-25T13:46:43Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+A Little About Myself
+~~~~~~~~~~~~~~~~~~~~~
+
+I am Mohamed from Egypt. , I am pursuing a Bachelor of Engineering in Computer Engineering and Automatic Control (expected: 2023), Tanta University, Egypt. 


Extra comma(,) after the first fullstop.

ganimtron-10 · 2022-05-25T13:47:09Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+I am Mohamed from Egypt. , I am pursuing a Bachelor of Engineering in Computer Engineering and Automatic Control (expected: 2023), Tanta University, Egypt. 
+I've been around computers since 2008 when I had my first PC with 128MB RAM and ran on Windows XP (that's almost all I could remember about it). 
+Around 2013 I started to have some questions about how games are made and how to make them myself!. 


Exclamation and fullstop both used at the end.

ganimtron-10 · 2022-05-25T13:52:44Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+
+
+Develpoing 3D game


typo correction Developing

ganimtron-10 · 2022-05-25T13:54:22Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+[https://youtu.be/CQY9c3oGJ3E]). 
+
+The next step was to implement the shader to make it work with FURY actors but then I knew I'm having a mandatory training required by the University last summer. I was disappointed and I decided to postpone till next year's GSoC.
+This year when the accepted organizations were pronounced I didn't bother to go through the list since I knew exactly which organization I'm going to apply for. So I just went directly to read the Ideas list for FURY.


typo - announced instead of pronounced

ganimtron-10 · 2022-05-25T13:55:20Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+The next step was to implement the shader to make it work with FURY actors but then I knew I'm having a mandatory training required by the University last summer. I was disappointed and I decided to postpone till next year's GSoC.
+This year when the accepted organizations were pronounced I didn't bother to go through the list since I knew exactly which organization I'm going to apply for. So I just went directly to read the Ideas list for FURY.
+The Keyframe animation system was the perfect fit! I've been arount keyframes for half of my life to even participate the required features before I read them! I then started to contribute and one contribution led to the other one.


typo - around

Thank you! I'm already working on them.

xtanion

Hii @m-agour , there are a few grammatical mistakes that I found on your blog. PTAL

xtanion · 2022-05-25T14:15:16Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+The day I got accepted
+~~~~~~~~~~~~~~~~~~~~~~
+I made it my mission for the day to keep watching the email for any changes. When It got 8:00 pm in the Cairo timezone I didn't see any changes. So I started searching for any news whatsoever and I couldn't find any. 


+1, add a coma

xtanion · 2022-05-25T14:16:14Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+The day I got accepted
+~~~~~~~~~~~~~~~~~~~~~~
+I made it my mission for the day to keep watching the email for any changes. When It got 8:00 pm in the Cairo timezone I didn't see any changes. So I started searching for any news whatsoever and I couldn't find any. 
+The GSoC dashboard doesn't say anything (story of my life. I didn't even get any promotions or spam mails that day). That's when I gave up. but, something doesn't feel right! right? I went again to check the dashboard to find that my proposal is accepted. but I can't even believe it. I'd better not jump to conclusions and wait for the official email before celebrating. shortly after, I received the official email It was a whole new feeling I never experienced ever before! I reached a whole new level of happiness.


But (Uppercase after a full stop)
Shortly
had never

too many but, try to find alternative

Fixed some punctuation mistakes and added some new information.

Removed additional colons

codecov · 2022-05-25T17:20:29Z

Codecov Report

Merging #586 (3d5c587) into master (38e9c1f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   87.96%   87.94%   -0.02%     
==========================================
  Files          62       62              
  Lines       13099    13099              
  Branches     1316     1316              
==========================================
- Hits        11522    11520       -2     
- Misses       1201     1202       +1     
- Partials      376      377       +1

Impacted Files	Coverage Δ
fury/fury/data/fetcher.py	`71.03% <0.00%> (-1.38%)`	⬇️

skoudoro

Hi @m-agour,

Thank you for this nice blog post. It is almost ready to be merged. Can you address the last comment below? Thanks!

Thanks @ganimtron-10 and @xtanion for the review

skoudoro · 2022-05-26T13:47:57Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+Around 2013, I had some questions about how games are made and how to make them myself!.
+There was no one to answer these questions for me.
+
+My English wasn't any good and the game development Arabic community was very hard to find on the internet. But eventually, I came across a forum with some people speaking about some stuff such as game engines, 3D models, textures, animations, and a lot of fun stuff. That made sense back then and answered some of my questions. Then It was time to get involved with this amazing community. I was lucky enough to start with 3ds Max 2009 Edition, with that little view cube begging me to touch it. It was just love at first sight).


sight) Why is there a closing bracket here ?

sight) Why is there a closing bracket here ?

After modifying the sentence, I accidentally left it there.

skoudoro · 2022-05-26T13:49:21Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+When I heard about OpenGL API for the first time from a senior and that it is being used to develop game engines, I started learning it along with GLSL.
+
+And it finally hit me: It is all math!.


no need of . after !

This one has not been resolved.

skoudoro · 2022-05-26T13:51:07Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+So, no Numpy, no PyGLM, fixed pipelines, no custom shaders, and each vertex had to be sent individually to the GPU.
+
+At first, I got disappointed, but while developing the game, I had a lot of optimization challenges that made me have fun figuring out how to still make the 3D game I’ve always wanted to make!.


no need of . after !

skoudoro · 2022-05-26T13:53:48Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+This year when the accepted organizations were pronounced, I didn’t bother to go through the list since I knew exactly which organization I’m going to apply for. So I just went directly to read the Ideas list for FURY.
+
+
+The Keyframe animation system was the perfect fit! I’ve been around keyframes for half of my life to even guess the required features before I read them!. I then started to contribute and one contribution led to the other one.


no need of . after !

skoudoro · 2022-05-26T13:54:25Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

@@ -0,0 +1,92 @@
+My journey till getting accepted into GSoC22
+================================================================================


too long, please, try to keep the same size as the title

skoudoro · 2022-05-26T13:54:58Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+The day I got accepted
+~~~~~~~~~~~~~~~~~~~~~~
+I made it my mission for the day to keep watching the email for any changes. When It got 8:00 pm in the Cairo timezone I didn't see any changes. So I started searching for any news whatsoever and I couldn't find any. 


+1, add a coma

skoudoro · 2022-05-26T13:56:07Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+The day I got accepted
+~~~~~~~~~~~~~~~~~~~~~~
+I made it my mission for the day to keep watching the email for any changes. When It got 8:00 pm in the Cairo timezone I didn't see any changes. So I started searching for any news whatsoever and I couldn't find any. 
+The GSoC dashboard doesn't say anything (story of my life. I didn't even get any promotions or spam mails that day). That's when I gave up. but, something doesn't feel right! right? I went again to check the dashboard to find that my proposal is accepted. but I can't even believe it. I'd better not jump to conclusions and wait for the official email before celebrating. shortly after, I received the official email It was a whole new feeling I never experienced ever before! I reached a whole new level of happiness.


too many but, try to find alternative

Fixed the underline being too long.

Added a missing comma.

Remove unnecessary full stop.

Altered some phrases.

Modified some sentences. Fixed some punctuation mistakes.

skoudoro

Hi @m-agour,

it would be great if you could check before pushing your code. The same mistake comes back and we would like to avoid reviewing the same mistake 4 times.

Thanks!

skoudoro · 2022-05-27T21:12:48Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+When I heard about OpenGL API for the first time from a senior and that it is being used to develop game engines, I started learning it along with GLSL.
+
+And it finally hit me: It is all math!.


This one has not been resolved.

skoudoro · 2022-05-27T21:13:55Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+
+I've been around computers since 2008 when I had my first PC with 128MB RAM and ran on Windows XP (that's almost all I could remember about it). 
+
+Around 2013, I had some questions about how games are made and how to make them myself!.


no need of . after !

skoudoro · 2022-05-27T21:15:27Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+Around 2013, I had some questions about how games are made and how to make them myself!.
+There was no one to answer these questions for me.
+
+My English wasn't any good and the game development Arabic community was very hard to find on the internet. But eventually, I came across a forum with some people speaking about some stuff such as game engines, 3D models, textures, animations, and a lot of fun stuff. That made sense back then and answered some of my questions. Then It was time to get involved with this amazing community. I was lucky enough to start with 3ds Max 2009 Edition, with that little view cube begging me to touch it. It was just love at first sight.


no need for uppercase for the words:

english

arabic

skoudoro · 2022-05-27T21:17:21Z

docs/source/posts/2022/2022-05-23-first-post-mohamed.rst

+This year when the accepted organizations were announced, I didn’t bother to go through the list since I knew exactly which organization I’m going to apply for. So I just went directly to read the Ideas list for FURY.
+
+
+The keyframe animation system was the perfect match! I have been around keyframes for half of my life to even guess the required features before I read them!. I then started to contribute and one contribution led to the other one.


no need of . after !

m-agour · 2022-05-28T15:38:33Z

Arabic

Hi @m-agour,

it would be great if you could check before pushing your code. The same mistake comes back and we would like to avoid reviewing the same mistake 4 times.

Thanks!

Sorry for that.

fixed some additional grammar mistakes.

The curly apostrophe wan not being rendered correctly in some RST viewers.

skoudoro

LGTM, thank you for the update.

Thanks @xtanion and @ganimtron-10 for the review.
merging

added first post

f3db0b6

ganimtron-10 reviewed May 25, 2022

View reviewed changes

xtanion reviewed May 25, 2022

View reviewed changes

m-agour changed the title ~~added first post~~ Added my first blog post May 25, 2022

m-agour added 2 commits May 25, 2022 18:59

Update 2022-05-23-first-post-mohamed.rst

017c15d

Fixed some punctuation mistakes and added some new information.

Update 2022-05-23-first-post-mohamed.rst

763d152

Removed additional colons

skoudoro reviewed May 26, 2022

View reviewed changes

m-agour added 5 commits May 26, 2022 17:05

Update 2022-05-23-first-post-mohamed.rst

fc838ae

Fixed the underline being too long.

Update 2022-05-23-first-post-mohamed.rst

3f0dcb0

Added a missing comma.

Update 2022-05-23-first-post-mohamed.rst

4c74fc6

Remove unnecessary full stop.

Update 2022-05-23-first-post-mohamed.rst

7f48027

Altered some phrases.

Update 2022-05-23-first-post-mohamed.rst

d4fbd11

Modified some sentences. Fixed some punctuation mistakes.

skoudoro reviewed May 27, 2022

View reviewed changes

m-agour added 2 commits May 28, 2022 17:43

Fixed some grammar mistakes.

818d1bb

fixed some additional grammar mistakes.

Fixed an encoding issue.

3d5c587

The curly apostrophe wan not being rendered correctly in some RST viewers.

skoudoro approved these changes May 30, 2022

View reviewed changes

skoudoro merged commit 7c4edf6 into fury-gl:master May 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added my first blog post #586

Added my first blog post #586

m-agour commented May 23, 2022

skoudoro commented May 23, 2022

ganimtron-10 left a comment

ganimtron-10 May 25, 2022

ganimtron-10 May 25, 2022

ganimtron-10 May 25, 2022

ganimtron-10 May 25, 2022

ganimtron-10 May 25, 2022

m-agour May 25, 2022

xtanion left a comment

xtanion May 25, 2022

skoudoro May 26, 2022

xtanion May 25, 2022

skoudoro May 26, 2022

codecov bot commented May 25, 2022 •

edited

skoudoro left a comment

skoudoro May 26, 2022

m-agour May 26, 2022 •

edited

skoudoro May 26, 2022

skoudoro May 27, 2022

skoudoro May 26, 2022

skoudoro May 26, 2022

skoudoro May 26, 2022

skoudoro May 26, 2022

skoudoro May 26, 2022

skoudoro left a comment

skoudoro May 27, 2022

skoudoro May 27, 2022

skoudoro May 27, 2022

skoudoro May 27, 2022

m-agour commented May 28, 2022

skoudoro left a comment


		When I heard about OpenGL API for the first time from a senior and that it is being used to develop game engines, I started learning it along with GLSL.

		And it finally hit me: It is all math!.


		So, no Numpy, no PyGLM, fixed pipelines, no custom shaders, and each vertex had to be sent individually to the GPU.

		At first, I got disappointed, but while developing the game, I had a lot of optimization challenges that made me have fun figuring out how to still make the 3D game I’ve always wanted to make!.

		This year when the accepted organizations were pronounced, I didn’t bother to go through the list since I knew exactly which organization I’m going to apply for. So I just went directly to read the Ideas list for FURY.


		The Keyframe animation system was the perfect fit! I’ve been around keyframes for half of my life to even guess the required features before I read them!. I then started to contribute and one contribution led to the other one.

		@@ -0,0 +1,92 @@
		My journey till getting accepted into GSoC22
		================================================================================


		I've been around computers since 2008 when I had my first PC with 128MB RAM and ran on Windows XP (that's almost all I could remember about it).

		Around 2013, I had some questions about how games are made and how to make them myself!.




		Develpoing 3D game

Added my first blog post #586

Added my first blog post #586

Conversation

m-agour commented May 23, 2022

skoudoro commented May 23, 2022

ganimtron-10 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xtanion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 25, 2022 • edited

Codecov Report

skoudoro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-agour May 26, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skoudoro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-agour commented May 28, 2022

skoudoro left a comment

Choose a reason for hiding this comment

codecov bot commented May 25, 2022 •

edited

m-agour May 26, 2022 •

edited