Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/compatible software #812

Merged
merged 5 commits into from Jun 30, 2023

Conversation

maharshi-gor
Copy link
Contributor

PR Details:

  • It includes changes for the new compatibility section on the FURY home page.
  • It works with both the PC and mobile devices.
  • The current inclusion of the software:

Unity, Autodesk, Adobe Dimension, Houdini, Modo, SketchUp

@maharshi-gor maharshi-gor mentioned this pull request Jun 29, 2023
@maharshi-gor
Copy link
Contributor Author

@ganimtron-10 @tvcastillod @JoaoDell
Please review this PR

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #812 (7965c78) into master (8710a65) will increase coverage by 33.96%.
The diff coverage is n/a.

❗ Current head 7965c78 differs from pull request most recent head 14ca499. Consider uploading reports for the commit 14ca499 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #812       +/-   ##
===========================================
+ Coverage   50.47%   84.43%   +33.96%     
===========================================
  Files         126       43       -83     
  Lines       28299    10274    -18025     
  Branches     3034     1393     -1641     
===========================================
- Hits        14284     8675     -5609     
+ Misses      13536     1239    -12297     
+ Partials      479      360      -119     

see 126 files with indirect coverage changes

Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mk996 ,
Thanks for doing this, LGTM.
The components are responsive too for all screen sizes.

Copy link
Contributor

@tvcastillod tvcastillod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mk996, I think that's a nice addition, overall looks great. I just have one minor comment below.

docs/source/_static/css/comp-soft.css Outdated Show resolved Hide resolved
@maharshi-gor
Copy link
Contributor Author

maharshi-gor commented Jun 30, 2023

Hi @tvcastillod, I have resolved the comment can you please review this again? I have made 50px on both ends as it was the standard size used around the page.

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the review @tvcastillod and @ganimtron-10 .

It looks good to me. Thank you for this work. Merging

@skoudoro skoudoro merged commit e595bad into fury-gl:master Jun 30, 2023
19 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants