Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pycodestyle stream #885

Merged
merged 17 commits into from
May 3, 2024
Merged

Conversation

WassCodeur
Copy link
Contributor

fix: style error using ruff [

@WassCodeur WassCodeur closed this Apr 29, 2024
@WassCodeur WassCodeur reopened this Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 85.44304% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 84.43%. Comparing base (14851c6) to head (4e767ff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
- Coverage   84.43%   84.43%   -0.01%     
==========================================
  Files          44       44              
  Lines       10537    10534       -3     
  Branches     1423     1423              
==========================================
- Hits         8897     8894       -3     
  Misses       1266     1266              
  Partials      374      374              
Files Coverage Δ
fury/animation/helpers.py 92.00% <ø> (ø)
fury/colormap.py 93.26% <ø> (ø)
fury/convert.py 80.00% <ø> (ø)
fury/deprecator.py 94.24% <100.00%> (ø)
fury/layout.py 98.61% <100.00%> (ø)
fury/molecular.py 100.00% <100.00%> (ø)
fury/primitive.py 95.58% <100.00%> (ø)
fury/stream/server/main.py 41.57% <ø> (ø)
fury/testing.py 89.41% <100.00%> (ø)
fury/transform.py 100.00% <100.00%> (ø)
... and 14 more

@skoudoro
Copy link
Contributor

Hi @WassCodeur,

Thank you for doing this.

As you can see here on the ci, there are still some issues: https://github.com/fury-gl/fury/actions/runs/8886182798/job/24399145996?pr=885#step:4:195

Can you address them? Then, it will be ready for review

@WassCodeur
Copy link
Contributor Author

HI @skoudoro
thank you for your feedback.

Sure, I can adress them

@pep8speaks
Copy link

pep8speaks commented May 1, 2024

Hello @WassCodeur, Thank you for updating!

Line 1127:80: E501 line too long (84 > 79 characters)

To test for issues locally, pip install flake8 and then run flake8 fury.

Comment last updated at 2024-05-02 14:15:34 UTC

@skoudoro
Copy link
Contributor

skoudoro commented May 3, 2024

Hi @WassCodeur,

There are still some issue but I will go ahead and merge. Thank you for doing this

@skoudoro skoudoro merged commit 342bf69 into fury-gl:master May 3, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants