RF: Add keyword arguments to module: animation #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WassCodeur
commented
Jun 20, 2024
WassCodeur
commented
- apply warn_on_args_to_kwargs to the module animation
- update the unitest
author WassCodeur <wachioubouraima56@gmail.com> 1716302141 +0000 committer WassCodeur <wachioubouraima56@gmail.com> 1717549770 +0000 NF: Add keyword_only decorator to enforce keyword-only arguments RF: Refactor keyword-only code and Add keyword-only arguments to functions TEST: Add test for keyword_only" decorator Refactor code to use keyword-only arguments in several functions NF: remove some doctest and add a short comment on line 111 to explain what the loop does in fury/decorators.py RF: Refactor keyword-only code and Add keyword-only arguments to functions Refactor code to use keyword-only arguments in several functions
- Renamed `keyword-only` decorator to `warn_on_args_to_kwargs` for greater clarity. - Updated `warn_on_args_to_kwargs` to include version parameters `from_version` and `until_version`. - Added logic to raise a RuntimeError if the current version of FURY_VERSION is greater than `until_version`. - Moved `__version__` definition to a new `fury/version.py` module to avoid circular import problems. - Updated all functions using the decorator to reflect the new name and parameters. - Adjusted import declarations and ensured compatibility across the code base.
…the warn_on_args_to_kwargs decorator
…gs arguments to functions in window.py and actor.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.