Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local files that start with file:/// #13

Closed
ndeubert opened this issue Sep 14, 2015 · 11 comments
Closed

Local files that start with file:/// #13

ndeubert opened this issue Sep 14, 2015 · 11 comments
Assignees
Milestone

Comments

@ndeubert
Copy link

Hello, Thanks for the extension, it is exactly what I was looking for, but I can't seem to get it to work with local urls that start with "file:///". Is there a special syntax for this?

@sylouuu
Copy link
Collaborator

sylouuu commented Sep 15, 2015

Hey @ndeubert,

It only works on websites because it's based on location.href. Moreover, the extension can't access to local files except if you have a website with a virtual host. Something like "localhost/...", "my-website.local"...

Bests

@sylouuu sylouuu closed this as completed Sep 15, 2015
@sylouuu
Copy link
Collaborator

sylouuu commented Sep 15, 2015

I reopen this issue because I've found something about file:// access.

@sylouuu sylouuu reopened this Sep 15, 2015
@sylouuu sylouuu modified the milestone: 0.6.0 Sep 15, 2015
@sylouuu
Copy link
Collaborator

sylouuu commented Sep 16, 2015

Hi @ndeubert,

Acutally, it's possible, see this commit.

This feature is planned for release 0.6.0 at the end of the month.

Bests

@sylouuu sylouuu self-assigned this Sep 16, 2015
@ndeubert
Copy link
Author

Excellent, merci beaucoup! I tried making the same patch to the
manifest.json file in my google-chrome config folder but that still did not
work for me. So I also tried replacing the js and html folders with the
latest ones from git but that also did not seem to work for me either. For
reference the URL I am trying to match is like this:
"file:///scratch/svn/ssh1/index.html?10.60.16.117&debug"

and my tab_modifier.json file has this:
{
"file://": {
"icon": "http://localhost/logos/soundtouch_32x32.png",
"pinned": true
}
}

On Wed, Sep 16, 2015 at 6:50 AM Syl notifications@github.com wrote:

Hi @ndeubert https://github.com/ndeubert,

Acutally, it's possible, see this commit
5a64229
.

This feature is planned for release 0.6.0 at the end of the month.

Bests


Reply to this email directly or view it on GitHub
#13 (comment)
.

@sylouuu
Copy link
Collaborator

sylouuu commented Sep 16, 2015

Your JSON file is OK but if you want to make it works just check the developer mode in chrome://extensions/.

Clone the repository & go to release/0.6.0.

git checkout release/0.6.0

Import the chrome-tab-modifier/dist folder as a developer extension & add your JSON in Options page.

@ndeubert
Copy link
Author

Got it working! Thank you again.

On Wed, Sep 16, 2015 at 11:55 AM Syl notifications@github.com wrote:

Your JSON file is OK but if you wan't to make it works just check the
developer mode in chrome://extensions/.

Clone the repository & go to release/0.6.0.

git checkout release/0.6.0

Import the chrome-tab-modifier/dist folder in a developer extension & add
your JSON.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@sylouuu
Copy link
Collaborator

sylouuu commented Sep 29, 2015

Supported in 0.6.0.

@sylouuu sylouuu closed this as completed Sep 29, 2015
@pierrethibault
Copy link

Hello. Just wanted to point out a caveat: not working in conjunction with SSL encrypted websites.
E.g. I have the entry:
"""
{
"mail.google.com": {
"icon": "file:///path_to_my_favicon.png"
}
}
"""
but the javascript console says:
"""
Mixed Content: The page at 'https://mail.google.com/mail[...]' was loaded over HTTPS, but requested an insecure favicon 'file:///path_to_my_icon.png'. This content should also be served over HTTPS.
"""

@sylouuu
Copy link
Collaborator

sylouuu commented Oct 6, 2015

@pierrethibault

You can't load a local favicon, you have to upload it somewhere.

This issue is related to detect local URL ie.:

{
   "file:///path_to_my_file.html": {
        "unique": true
    }
}

@pierrethibault
Copy link

Alright sorry for the confusion.

@sylouuu
Copy link
Collaborator

sylouuu commented Nov 3, 2016

Quick note to say that this case is listed in the README with few workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants