Changes script interaction to support SPAs #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix context menu creation error with non-persistent background.js
change: inject content script only when url has rules add: retry to extract DOM selector every X++ seconds 50 times and some other stuff.
|
@sylouuu What do you think of that commit? I think others would benefit from it. |
|
Hey @sylouuu to remind you to accept this Pull Request. |
|
Gooood morning @sylouuu !!! :_D Any plans to accept this Pull Request? |
|
Thanks for your work. As I said in #180 I have no plan to work on TM at the moment. Even if I merge this, I won't release a new version, etc. Thanks for your understanding! |
|
Hi @MartinLichtblau, The entire code base has been rewritten. If this is still needed, can you contribute again? Tab Modifier 1.0 is now available! Feel free to open a new PR, Bests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sylouuu I auto formatted the code and created some unnecessary changes. I also didnt't know whether the /dist needs to be generated from the /src when only the content and backround script changed; so I just copied it by hand. So this closes #185 (my isssue)
Since it works with SPAs now it fixes #168 fixes #168 fixes #105 fixes #93 fixes #64
Related fixes
Could fix:
Interoperability with Blue Dot Replacement extension #177 Chosen custom icon for a tab only visible once #158