Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

Fix it for there is no file in the local file system #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juscelior
Copy link

@juscelior juscelior commented Mar 10, 2017

Fix it because there is no file in the local file system and you want to use MD5 hash.
An example would be to use the SignalR, it creates a route / signalr / hubs, but this route is just virtual. There is no such script in the project directory.

@juscelior juscelior changed the title Fix it for there is no file in the local file system and you want to … Fix it for there is no file in the local file system Mar 10, 2017
@davinkevin
Copy link
Collaborator

Thanks for the contribution.

Do you think it's a good idea to prevent error if file doesn't exist ? Sometimes this error help me to see other problem...

@juscelior
Copy link
Author

Look at this link , this library creates a virtual route to a js file, but this file is not created on the file system

<script src="signalr/hubs"></script>

@davinkevin
Copy link
Collaborator

I think we should have a flag to show the error, because this is changing the behaviour of the script.
This flag by défaut should raise exception and you will have to change its value on your virtualisation file context.

Could you integrate it ?

BTW, thanks for your contribution 👍

@juscelior
Copy link
Author

Good idea, I'll do it.

@Djuuu
Copy link

Djuuu commented Mar 23, 2017

Maybe another way to deal with the problem would be to add configurable exclusion patterns?
That way, we could bypass busting for specific use cases and still raise errors for inadvertently missing files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants