Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Update the condition for vue HMR #1120

Merged
merged 1 commit into from Feb 21, 2018
Merged

Update the condition for vue HMR #1120

merged 1 commit into from Feb 21, 2018

Conversation

orblazer
Copy link
Contributor

Hello, i have add function isRecorded on vue-hot-reload-api (this PR).

Now the VueComponentPlugin require vue-hot-reload-api@^2.3.0.

I have two question, would not it be better to add plugin dependencies in peerDependencies.
Do you want replace ws lib by uws for have more performance on HMR and less dependencies.
End for end, the watch dependencies is not used ?
Yep i search how to reduce dependencies size :)

Thanks.

@nchanged
Copy link
Contributor

Great! There are quite many peerDeps, I am not sure if adding all of them is a good idea.
uws that's a library? We can, but there are many places that would require refactoring.

@nchanged nchanged merged commit 83c44ab into fuse-box:master Feb 21, 2018
@orblazer
Copy link
Contributor Author

Ok, if you want i can make the refactoring in next days.

@nchanged
Copy link
Contributor

@orblazer You have to be very careful with that one. You can't break the API

@orblazer
Copy link
Contributor Author

Yes, i know.

@nchanged
Copy link
Contributor

@orblazer Try to make it simpler to review, I will be very strict with it because this change can affect a lot of projects. ;-)

@nchanged
Copy link
Contributor

And BTW, thanks a lot for contributing! I really appreciate it! I hope we can get more people onboard!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants