Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

more docs #149

Merged
merged 13 commits into from Feb 13, 2017
Merged

more docs #149

merged 13 commits into from Feb 13, 2017

Conversation

basarat
Copy link
Contributor

@basarat basarat commented Feb 12, 2017

🌹

@basarat
Copy link
Contributor Author

basarat commented Feb 13, 2017

Note to self:

  • Resolve merge conflicts
  • Revert all changes to CSSBundle
  • Rename context emitter to sourceChangedEmitter

Will action these tomorrow 🌹

@basarat basarat force-pushed the bas/docs7 branch 3 times, most recently from 1bf559f to f15a62c Compare February 13, 2017 22:46
Basarat Ali Syed added 6 commits February 14, 2017 09:59
Only one actual bug caught:
`import * as process from 'process';` was invalid as process is not in our package.json
- Because TypeScript complains about unused parameter otherwise
@basarat
Copy link
Contributor Author

basarat commented Feb 13, 2017

@nchanged actioned the items as discussed. Ready to review again 👍 ❤️

@nchanged
Copy link
Contributor

Love it! @basarat you are the best! 🥇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants