Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

change brightBlack to reset get neutral color on dark themes #190

Merged
merged 1 commit into from Feb 16, 2017
Merged

change brightBlack to reset get neutral color on dark themes #190

merged 1 commit into from Feb 16, 2017

Conversation

kyeotic
Copy link
Contributor

@kyeotic kyeotic commented Feb 16, 2017

To fix #173.

Grey colors do not show up on solarized dark (and a few others). But the neutral color is already grey.

Here is solarized dark before the change (with some highlighing to show the invisible text)
image

Here is solarized dark after the change
image

For extra comparison here is Solarized light before and after
image

image

I tested several other themes just to be sure, but since this uses reset() it should be safe everywhere.

@kyeotic
Copy link
Contributor Author

kyeotic commented Feb 16, 2017

I forgot to mention, I tried the other grey/black/bright colors, but they produced poor looking reports. White looked ok, but it seemed to break the intention of the muted color brightBlack is supposed to produce. All the actual colors clashed with the green and yellow in the report.

@nchanged nchanged added this to the 1.3.116 milestone Feb 16, 2017
@nchanged
Copy link
Contributor

Good job! Thanks a lot!

@nchanged nchanged merged commit 0e730b7 into fuse-box:master Feb 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle 2nd level color is invisible on solarized dark
2 participants