This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
change brightBlack to reset get neutral color on dark themes #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #173.
Grey colors do not show up on solarized dark (and a few others). But the neutral color is already grey.
Here is solarized dark before the change (with some highlighing to show the invisible text)
Here is solarized dark after the change
For extra comparison here is Solarized light before and after
I tested several other themes just to be sure, but since this uses
reset()
it should be safe everywhere.