This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fluent #353
Merged
Fluent #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✚ add support for nocache 🔍🖇 add missing str includes any of util 🌊 convert to typescript
✨ add noApi to include
nchanged
reviewed
Mar 6, 2017
src/tests/Arithmetic.test.ts
Outdated
| "isArithmetic should detect arithmetics properly"() { | ||
| const isArithmeticTrue = Fluent.isArithmetic('!^>[index.js] +[**/*.js] -path') | ||
| const isArithmeticFalse = Fluent.isArithmetic('eh...') | ||
| should(isArithmeticTrue).deepEqual(true) |
src/tests/Arithmetic.test.ts
Outdated
| .finishBundle() | ||
| .finish() | ||
|
|
||
| should(typeof singleBundle).deepEqual('string') |
There was a problem hiding this comment.
should(singleBundle).beString().equal("actual string should be here")
src/tests/Arithmetic.test.ts
Outdated
| .finishBundle() | ||
| .finish() | ||
|
|
||
| should(typeof multipleBundles).deepEqual('object') |
There was a problem hiding this comment.
beObject().deepEqual(/* would be cool to have results here */)
src/tests/Arithmetic.test.ts
Outdated
| let parsed = Arithmetic.parse(singleBundle); | ||
|
|
||
| should(parsed.str.includes('!')) | ||
| .deepEqual(true) |
src/tests/Arithmetic.test.ts
Outdated
|
|
||
| const singleBundle = result.finish() | ||
|
|
||
| should(typeof singleBundle).deepEqual('string') |
There was a problem hiding this comment.
beString().equal("actual string")
src/arithmetic/Fluent.ts
Outdated
| public arithmetics: string; | ||
| public noDeps: boolean; | ||
|
|
||
| constructor(name, arithmetics) { |
There was a problem hiding this comment.
public arithmetics : string
src/arithmetic/Fluent.ts
Outdated
| this.cmds = [] | ||
| this.str = `` | ||
| this.name = name | ||
| this.arithmetics = arithmetics |
👾 shorter ts syntax for constructors
✚🔬 add more thorough tests following the standard testing formula 📦 export Fluent in index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#336
🗑 remove old implementation in index
👾 simplify
🔍🖇 add missing str includes any of util
🌊 convert to typescript
🔬 tests for all
📦 import export Fluent in Arithmetics
✚ add support for nocache
✚ check for ^ & ~ in isArithmetic