pack.sh: support building outside of Git #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't terminate the script if a git command fails. This fixes building .tar.gz files downloaded from GitHub, reported broken in https://forums.fusetools.com/t/unable-to-compile-uno-fatal-not-a-git-repository/7817/1
kusma
reviewed
Jul 25, 2019
kusma
approved these changes
Jul 26, 2019
mortend
added a commit
to mortend/uno
that referenced
this pull request
Sep 30, 2019
* When building on AppVeyor:
Drop prerelease-suffix on tagged commits (official releases),
or use canary-suffix on when building the master-branch,
or use rc-suffix on when building a release-branch.
* When building from Git repo:
Get commit SHA from local git-repo.
Always use dev-suffix.
* Otherwise:
Always use dev-suffix.
Following up a little bit on fuse-open#208, I think this new logic is less awkward.
I also added a canary-suffix on master-builds, and the idea is to set up a
canary-channel on NPM where we can easily publish the latest master-build.
Merged
mortend
added a commit
to mortend/uno
that referenced
this pull request
Oct 7, 2019
* When building on AppVeyor:
Drop prerelease-suffix on tagged commits (official releases),
or set canary-suffix when building the master-branch,
or set rc-suffix when building a release-branch.
* When building from Git repo:
Get commit SHA from local git-repo.
Always set dev-suffix.
* Otherwise:
Always set dev-suffix.
Following up a little bit on fuse-open#208, I think this new logic is less awkward.
I also added a canary-suffix on master-builds, and the idea is to set up a
canary-channel on NPM where we can easily publish the latest master-build.
mortend
added a commit
to mortend/uno
that referenced
this pull request
Nov 11, 2019
* When building on AppVeyor:
Drop prerelease-suffix on tagged commits (official releases),
or set canary-suffix when building the master-branch,
or set rc-suffix when building a release-branch.
* When building from Git repo:
Get commit SHA from local git-repo.
Always set dev-suffix.
* Otherwise:
Always set dev-suffix.
Following up a little bit on fuse-open#208, I think this new logic is less awkward.
I also added a canary-suffix on master-builds, and the idea is to set up a
canary-channel on NPM where we can easily publish the latest master-build.
mortend
added a commit
to mortend/uno
that referenced
this pull request
Nov 14, 2019
This drops $BRANCH and $SUFFIX, and simplifies logic (fuse-open#208). When updating an NPM package, the version field must be updated in package.json, and all changes to package.json should be committed in Git. This means that publishing an NPM package, pre-release or not, will always involve updating package.json, committing, and pushing a tag in Git. This also means that pack.sh should not manipulate version info read from package.json, as it used to do in pre-NPM times for legacy reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't terminate the script if a git command fails.
This fixes building .tar.gz files downloaded from GitHub, reported broken in
https://forums.fusetools.com/t/unable-to-compile-uno-fatal-not-a-git-repository/7817/1