Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor #29

Merged
merged 2 commits into from
Mar 20, 2023
Merged

[WIP] Refactor #29

merged 2 commits into from
Mar 20, 2023

Conversation

LiorAgnin
Copy link
Member

No description provided.

@LiorAgnin
Copy link
Member Author

@SametSahin10 Feel free to propose any refactoring or improvements.

SametSahin10
SametSahin10 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@SametSahin10 SametSahin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed it briefly. Nice improvements! I'd never say no to renaming variables, classes to achieve better readability. I was not keen on the word "section". "module" is better.

@SametSahin10 SametSahin10 merged commit 5fe4717 into master Mar 20, 2023
@SametSahin10
Copy link
Collaborator

I've merged it. Could you publish a new version on pub.dev? @LiorAgnin

@LiorAgnin LiorAgnin mentioned this pull request Mar 20, 2023
Closed
@LiorAgnin
Copy link
Member Author

@SametSahin10 You should not have merged it; it's still a work in progress. We will have more improvements.

@SametSahin10
Copy link
Collaborator

Oh, sorry. I thought you're willing to merge it when you requested my review. @LiorAgnin

@LiorAgnin
Copy link
Member Author

It's ok, I fixed it. I reopened the PR. @SametSahin10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SametSahin10 SametSahin10 SametSahin10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LiorAgnin @SametSahin10