Added basic set of unit tests for gitea/client.go #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefannica
reviewed
Apr 20, 2021
stefannica
reviewed
Apr 20, 2021
There was a problem hiding this comment.
Looks great, thank you.
Based on this first occurrence, I'm slightly concerned that we'll need a lot of code in order to mock the behavior of external services like the gitea server here. For example, I assume we'll need to do the same for the tekton client, and expand this fake gitea server to cover API calls related to git repository contents: tags, commits, branches etc.
On the other hand, I agree with this approach, even more so since I can't think of a better solution.
Also add logger option to giteaAdminClient struct to make it possible to change the logger or suppress it complete e.g. during test run. Also rename methods in our API so they do not have the same name as Gitea API to reduce possible confusion
stefannica
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10