Remove Current Codest from config file when it was delete #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting Codeset, make sure it does not stay in config file as CurrentCodeset. Related to #244
This is important so that user recognizes that values are being read from a config file if not provided on command line.
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 68.71% 68.59% -0.13%
==========================================
Files 9 9
Lines 1576 1576
==========================================
- Hits 1083 1081 -2
- Misses 375 377 +2
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stefannica
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting Codeset, make sure it does not stay in config file
as CurrentCodeset.
Related to #244