Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core deployment: read the values from configmap #100

Closed
jsuchome opened this issue May 20, 2021 · 0 comments · Fixed by #117
Closed

core deployment: read the values from configmap #100

jsuchome opened this issue May 20, 2021 · 0 comments · Fixed by #117
Assignees
@jsuchome
Labels
area/installer Installation related requests enhancement New feature or request
Projects
FuseML Project Board

Comments

@jsuchome
Copy link
Member

when deploying core service, fuseml-installer reads the yaml file and replaces some strings (e.g. with gitea url). Cleaner solution would be

"creating a config map with those values and making the deployment read it from there." (@flaviodsr )
@jsuchome jsuchome added enhancement New feature or request area/installer Installation related requests labels May 20, 2021
@jsuchome jsuchome self-assigned this Jun 1, 2021
jsuchome added a commit to jsuchome/fuseml that referenced this issue Jun 1, 2021
@jsuchome
fix: Create ConfigMap for GITEA and TEKTON URLs
de8af5f 
No need to parse and sed the yaml template. Closes fuseml#100
@jsuchome jsuchome mentioned this issue Jun 1, 2021
Merged
@stefannica stefannica added this to Backlog in FuseML Project Board via automation Jun 1, 2021
@stefannica stefannica moved this from Backlog to In progress in FuseML Project Board Jun 1, 2021
jsuchome added a commit to jsuchome/fuseml that referenced this issue Jun 1, 2021
@jsuchome
fix: Create ConfigMap for GITEA and TEKTON URLs
2193dcf 
No need to parse and sed the yaml template. Closes fuseml#100
FuseML Project Board automation moved this from In progress to Done Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuchome jsuchome

Labels
area/installer Installation related requests enhancement New feature or request
Projects
FuseML Project Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Create ConfigMap for GITEA and TEKTON URLs jsuchome/fuseml
1 participant
@jsuchome