Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuseml application delete fails to delete k8s resources #107

Closed
jsuchome opened this issue May 26, 2021 · 0 comments · Fixed by #108
Closed

fuseml application delete fails to delete k8s resources #107

jsuchome opened this issue May 26, 2021 · 0 comments · Fixed by #108
Assignees
@jsuchome
Labels
area/core bug Something isn't working
Projects
FuseML Project Board

Comments

@jsuchome
Copy link
Member

Deleting of an application fails with

User \"system:serviceaccount:fuseml-core:fuseml-core-tekton\" cannot delete resource \"inferenceservices\" in API group \"serving.kubeflow.org\" in the namespace \"fuseml-workloads\""

The problem is, we could just add the permission to delete inferenceservices, however the applications are formed of multiple resources.

For current test application we have

  - name: mlflow-project-01-mlflow-test-storage
    kind: Secret
  - name: mlflow-project-01-mlflow-test-kfserving
    kind: ServiceAccount
  - name: mlflow-project-01-mlflow-test
    kind: InferenceService

And such list will grow with new kind of applications...
@jsuchome jsuchome added bug Something isn't working area/core labels May 26, 2021
jsuchome added a commit to jsuchome/fuseml that referenced this issue May 26, 2021
@jsuchome
Give the admin rights to fuseml-core ServiceAccount
58b0787 
This is fuseml-core can delete various resources forming FuseML
applications (secrets, serviceaccounts, inferenceservices etc.)

Closes fuseml#107
@jsuchome jsuchome mentioned this issue May 26, 2021
Merged
jsuchome added a commit to jsuchome/fuseml that referenced this issue May 26, 2021
@jsuchome
fix: Give the admin rights to fuseml-core ServiceAccount
81169ed 
This is fuseml-core can delete various resources forming FuseML
applications (secrets, serviceaccounts, inferenceservices etc.)

Closes fuseml#107
@jsuchome jsuchome self-assigned this May 26, 2021
@jsuchome jsuchome added this to Backlog in FuseML Project Board via automation May 26, 2021
@jsuchome jsuchome moved this from Backlog to In progress in FuseML Project Board May 26, 2021
jsuchome added a commit to jsuchome/fuseml that referenced this issue Jun 1, 2021
@jsuchome
fix: Give the admin rights to fuseml-core ServiceAccount
5e4ef97 
This is fuseml-core can delete various resources forming FuseML
applications (secrets, serviceaccounts, inferenceservices etc.)

Closes fuseml#107
jsuchome added a commit to jsuchome/fuseml that referenced this issue Jun 1, 2021
@jsuchome
fix: Give the admin rights to fuseml-core ServiceAccount
27618bf 
This is fuseml-core can delete various resources forming FuseML
applications (secrets, serviceaccounts, inferenceservices etc.)

Closes fuseml#107
FuseML Project Board automation moved this from In progress to Done Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuchome jsuchome

Labels
area/core bug Something isn't working
Projects
FuseML Project Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give the admin rights to fuseml-core ServiceAccount jsuchome/fuseml
1 participant
@jsuchome