Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer: extensions should have dependencies #188

Closed
jsuchome opened this issue Jul 30, 2021 · 0 comments · Fixed by #189
Closed

installer: extensions should have dependencies #188

jsuchome opened this issue Jul 30, 2021 · 0 comments · Fixed by #189
Assignees
@jsuchome
Labels
area/installer Installation related requests feature
Projects
FuseML Project Board

Comments

@jsuchome
Copy link
Member

If an extension has defined dependency (say, kfserving requires knative), installer should take care about installing all dependencies without the need for user to install them explicitly.
@jsuchome jsuchome added area/installer Installation related requests feature labels Jul 30, 2021
@jsuchome jsuchome added this to Backlog in FuseML Project Board via automation Jul 30, 2021
@jsuchome jsuchome self-assigned this Jul 30, 2021
jsuchome added a commit to jsuchome/fuseml that referenced this issue Jul 30, 2021
@jsuchome
feat: Add support for extension dependencies
c49799e 
Now if an extension has a defined requirement, all required
extensions should be automatically installed first.

When uninstalling, "top level" (those with dependencies) extensions
get uninstalled first.

Closes fuseml#188
@jsuchome jsuchome mentioned this issue Jul 30, 2021
Merged
FuseML Project Board automation moved this from Backlog to Done Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuchome jsuchome

Labels
area/installer Installation related requests feature
Projects
FuseML Project Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for extension dependencies jsuchome/fuseml
1 participant
@jsuchome