-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't (re)install an extension if it's already running #205
Comments
This is actually already implemented |
#274 solves at least some of the issues mentioned:
So, this should be solved; if such kind of dependency is already there, FuseML skips its installation, assuming the requirements are met.
OK, so in this case, FuseML tries to reinstall the extension (unless it's a helm chart!). We need to think if it is good/bad/good enough... I think it does not necessary mean it is bad: what could possibly go wrong here? If the same manifest is applied again, Kubernetes itself is able to recognize if some object needs to be (re)created or not. The possibly good part of it is that this might be a way to "fix" broken installations of an extension... |
So, We can add an option to turn it off and behave just like with 3rd party extensions: whenever an existing namespace is detected, skip the installation. Now, the question is, what should be the default: "force reinstallation" or "keep detected"? |
Until now, reinstalation was the default option for non-helm based exensions. This PR; - changes the default behavior: if fuseml finds existing extension, it will not touch it - add new command line argument ("--force-reinstall") that allows user to reinstall extensions that were previously installed by FuseML. The extensions installed by third party won't be touched in either case. Closes fuseml#205
Until now, reinstalation was the default option for non-helm based exensions. This PR; - changes the default behavior: if fuseml finds existing extension, it will not touch it - add new command line argument ("--force-reinstall") that allows user to reinstall extensions that were previously installed by FuseML. The extensions installed by third party won't be touched in either case. Closes fuseml#205
Until now, reinstalation was the default option for non-helm based exensions. This PR; - changes the default behavior: if fuseml finds existing extension, it will not touch it - add new command line argument ("--force-reinstall") that allows user to reinstall extensions that were previously installed by FuseML. The extensions installed by third party won't be touched in either case. Closes fuseml#205
When installing an extension through the
fuseml-installer
, there are some use cases concerning existing installations of that extension and its dependencies that need to be addressed:Addressing this using a general strategy is preferable, but not easy to define. First, we need a general mechanism that we can use to "detect" existing installations, both those that are managed by FuseML and those that are not. Here are some suggestions:
What to do when an extension or dependency is "detected":
--force-reinstall
) flagThe text was updated successfully, but these errors were encountered: