Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuseml uninstall fails when no extensions were installed #270

Closed
jsuchome opened this issue Oct 12, 2021 · 1 comment · Fixed by #271
Closed

fuseml uninstall fails when no extensions were installed #270

jsuchome opened this issue Oct 12, 2021 · 1 comment · Fixed by #271
Labels
area/helm-chart area/installer Installation related requests

Comments

@jsuchome
Copy link
Member

When uninstalling, fuseml-installer first removes the extensions. However if no extensions were installed, uninstallation fails already at extensions phase and does not proceed with uninstallation of main components

This is simple when running the installer from command line: just do not provide extensions list. But with helm charts, extensions are remembered from the values passed during installation and it does not seem possible to change it when uninstalling.

The uninstall command must be modified then, e.g. to ignore the argument but uninstall all extensions that are actually registered.
@jsuchome jsuchome added area/installer Installation related requests area/helm-chart labels Oct 12, 2021
jsuchome added a commit to jsuchome/charts that referenced this issue Oct 13, 2021
@jsuchome
FuseML chart: Do not run uninstall command with extensions
f0a29f7 
If extensions were not properly installed, it is going to fail.

Related to fuseml/fuseml#270
@jsuchome
Copy link
Member Author

Should be ported to 0.2

jsuchome added a commit to jsuchome/fuseml that referenced this issue Oct 13, 2021
@jsuchome
fix: When extensions are not specified, uninstall all
9d8d3c7 
During uninstall command, one can specify extensions to uninstall,
but it is actually more useful to uninstall all registered extensions,
especially for the case when user does not know what is installed.

Closes fuseml#270
@jsuchome jsuchome mentioned this issue Oct 13, 2021
Merged
1 task
jsuchome added a commit to jsuchome/fuseml that referenced this issue Oct 14, 2021
@jsuchome
fix: When extensions are not specified, uninstall all
d0298bc 
During uninstall command, one can specify extensions to uninstall,
but it is actually more useful to uninstall all registered extensions,
especially for the case when user does not know what is installed.

Closes fuseml#270
jsuchome added a commit to jsuchome/fuseml that referenced this issue Oct 15, 2021
@jsuchome
fix: When extensions are not specified, uninstall all
3420dbe 
During uninstall command, one can specify extensions to uninstall,
but it is actually more useful to uninstall all registered extensions,
especially for the case when user does not know what is installed.

Closes fuseml#270

(cherry picked from commit d0298bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm-chart area/installer Installation related requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: When extensions are not specified, uninstall all that are registered jsuchome/fuseml
1 participant
@jsuchome