Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuseML should detect 3rd party extensions and not try to reinstall them #273

Closed
jsuchome opened this issue Oct 14, 2021 · 0 comments · Fixed by #274
Closed

FuseML should detect 3rd party extensions and not try to reinstall them #273

jsuchome opened this issue Oct 14, 2021 · 0 comments · Fixed by #274
Labels
area/installer Installation related requests

Comments

@jsuchome
Copy link
Member

If an extension (cert-manager, kfserving...) is already installed in the cluster and fuseml-installer is told to install it, it should be able to detect existing ones and just calmly skip the installation without raising an error.

This could be done by simply checking for existence of a namespace, in a simplest case. If we want to be more sure, we could check for some specific resource in given namespace, and the name of such resource needs to be provided via description.yaml file.

Related to #272 : such 3rd party extensions would not be deleted when uninstalling FuseML because their namespace would not be labeled by FuseML.
@jsuchome jsuchome added the area/installer Installation related requests label Oct 14, 2021
jsuchome added a commit to jsuchome/fuseml that referenced this issue Oct 14, 2021
@jsuchome
fix: Make sure to not break 3rd party extensions
a8072b0 
By labeling the namespaces created for extensions,
make sure to

- detect existing extensions and not overwrite them (closes fuseml#273)
- only delete the extensions that were installed by fuseml (closes fuseml#272)
@jsuchome jsuchome mentioned this issue Oct 14, 2021
Merged
jsuchome added a commit to jsuchome/fuseml that referenced this issue Oct 14, 2021
@jsuchome
fix: Make sure to not break 3rd party extensions
208befc 
By labeling the namespaces created for extensions,
make sure to

- detect existing extensions and not overwrite them (closes fuseml#273)
- only delete the extensions that were installed by fuseml (closes fuseml#272)
jsuchome added a commit to jsuchome/fuseml that referenced this issue Oct 14, 2021
@jsuchome
fix: Make sure to not break 3rd party extensions
6a1bb0d 
By labeling the namespaces created for extensions,
make sure to

- detect existing extensions and not overwrite them (closes fuseml#273)
- only delete the extensions that were installed by fuseml (closes fuseml#272)
jsuchome added a commit to jsuchome/fuseml that referenced this issue Oct 15, 2021
@jsuchome
fix: Make sure to not break 3rd party extensions
b3dd374 
By labeling the namespaces created for extensions,
make sure to

- detect existing extensions and not overwrite them (closes fuseml#273)
- only delete the extensions that were installed by fuseml (closes fuseml#272)

(cherry picked from commit 6a1bb0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/installer Installation related requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make sure to not break 3rd party extensions jsuchome/fuseml
1 participant
@jsuchome