Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Dockerfile for fuseml-core #57

Closed
flaviodsr opened this issue Apr 9, 2021 · 0 comments · Fixed by fuseml/fuseml-core#6
Closed

Create Dockerfile for fuseml-core #57

flaviodsr opened this issue Apr 9, 2021 · 0 comments · Fixed by fuseml/fuseml-core#6
Assignees
@flaviodsr
Projects
FuseML Project Board Fuseml Repo

Comments

@flaviodsr
Copy link
Member

As an application that runs on Kubernetes, we need a docker image for fuseml-core.

Initially, the image can be based on https://hub.docker.com/_/scratch having only the fuseml-core binary.
@flaviodsr flaviodsr self-assigned this Apr 9, 2021
flaviodsr added a commit to flaviodsr/fuseml-core that referenced this issue Apr 9, 2021
@flaviodsr
Add Dockerfile for fuseml-core
c607c09 
Add a dockerfile for building the container image for fuseml-core,
the dockerfile contains 2 stages:
  1. build fuseml-core using golang image
  2. build the fuseml-core container image from docker scratch by simple
    copying the binary built on stage 1 to it and use that as entrypoint.

This change also adds new targets into the makefile for building the
container image and running tests/fuseml_core/fuseml_core-cli.

Resolves: fuseml/fuseml#57
@flaviodsr flaviodsr mentioned this issue Apr 9, 2021
Merged
flaviodsr added a commit to flaviodsr/fuseml-core that referenced this issue Apr 12, 2021
@flaviodsr
Add Dockerfile for fuseml-core
bcc2fe7 
Add a dockerfile for building the container image for fuseml-core,
the dockerfile contains 2 stages:
  1. build fuseml-core using golang image
  2. build the fuseml-core container image from docker scratch by simple
    copying the binary built on stage 1 to it and use that as entrypoint.

This change also adds new targets into the makefile for building the
container image and running tests/fuseml_core/fuseml_core-cli.

Resolves: fuseml/fuseml#57
@stefannica stefannica added this to To do in FuseML Project Board via automation Apr 12, 2021
@stefannica stefannica added this to To do in Fuseml Repo via automation Apr 12, 2021
@stefannica stefannica moved this from To do to In progress in FuseML Project Board Apr 12, 2021
@stefannica stefannica moved this from To do to In progress in Fuseml Repo Apr 12, 2021
flaviodsr added a commit to flaviodsr/fuseml-core that referenced this issue Apr 14, 2021
@flaviodsr
Add Dockerfile for fuseml-core
98b40cb 
Add a dockerfile for building the container image for fuseml-core,
the dockerfile contains 2 stages:
  1. build fuseml-core using golang image
  2. build the fuseml-core container image from docker scratch by simple
    copying the binary built on stage 1 to it and use that as entrypoint.

This change also adds new targets into the makefile for building the
container image and running tests/fuseml_core/fuseml_core-cli.

Resolves: fuseml/fuseml#57
flaviodsr added a commit to flaviodsr/fuseml-core that referenced this issue Apr 22, 2021
@flaviodsr
Add Dockerfile for fuseml-core
0947a06 
Add a dockerfile for building the container image for fuseml-core,
the dockerfile contains 2 stages:
  1. build fuseml-core using golang image
  2. build the fuseml-core container image from docker scratch by simple
    copying the binary built on stage 1 to it and use that as entrypoint.

This change also adds new targets into the makefile for building the
container image and running tests/fuseml_core/fuseml_core-cli.

Resolves: fuseml/fuseml#57
FuseML Project Board automation moved this from In progress to Done Apr 23, 2021
Fuseml Repo automation moved this from In progress to Done Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviodsr flaviodsr

Labels
None yet
Projects
FuseML Project Board
  
Done
Fuseml Repo
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Dockerfile for fuseml-core flaviodsr/fuseml-core
1 participant
@flaviodsr