Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve target host configuration #4

Merged
merged 1 commit into from Mar 19, 2017
Merged

Improve target host configuration #4

merged 1 commit into from Mar 19, 2017

Conversation

fusepilot
Copy link
Owner

This simplifies the host configuration. And in spirit with CRA, targets all known Adobe hosts by default with the version set to [0.0,99.9]. So now, instead of users having to find the right host id and version for whichever app they're targeting, it will just work.

@fusepilot
Copy link
Owner Author

This still doesn't allow for configuration of specific host name and host version combos. I'd prefer to not add additional configuration somewhere else, either in package.json or something like a cep.json unless its really necessary since it doesn't really jibe well CRA philosophy.

If it is needed though, we could do something like:

EXTENSION_HOSTS="PHXS@[16.0,16.9], AEFT@[13.5,16.0]"

What do you think @kennethormandy?

@kennethormandy
Copy link
Contributor

Making it support everything by default is a great change, one less decision to make when you’re getting started.

The version number syntax is clear to me, nice that it’s all in one variable again. I agree about avoiding the other config—I didn’t realise that CRA used environment variables, so that all makes more sense to me now.

@fusepilot fusepilot merged commit e25b24b into master Mar 19, 2017
@fusepilot
Copy link
Owner Author

Cool! Thanks for the feedback.

@fusepilot fusepilot deleted the host-manifest branch March 19, 2017 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants