Make use of cep-bundler-core #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I moved the "bundler specific code" into a separate package, hoping we can stop duplicating efforts for the code we use to create the manifest.xml, .debug file, copy node modules / icons etc.
This pull request integrates
cep-bundler-core, which has deviated a little bit from the current implementation in this library. The main (breaking) change is the renaming of the environment variables, prefixing them withCEP_(all the available environment variables / config options are on it's readme)I am also using
cep-bundler-corenow in my new webpack based bundler over herePlease let me know what you think about it.