Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ascii chars incorrectly handled on Windows 7 with IBM JDK #93

Closed
andham opened this issue Sep 12, 2017 · 4 comments
Closed

Non-ascii chars incorrectly handled on Windows 7 with IBM JDK #93

andham opened this issue Sep 12, 2017 · 4 comments

Comments

@andham
Copy link

andham commented Sep 12, 2017

Non-ascii chars (å, ä, ö for example) are displayed as question mark ('?') on Windows 7 when using IBM JDK 1.8. With Oracle JDK 1.8 it works.
This was originally reported on the Apache Maven project: https://issues.apache.org/jira/browse/MNG-6205
IBM JDK can be downloaded here: https://www.ibm.com/developerworks/java/jdk/

One way to test is to add the following line to Main.java in the example module:
System.out.println("System.out: " + "åäö");

@hboutemy
Copy link
Collaborator

Anders, can you check this PR please? It should fix the issue since any encoding management is removed by extending PrintStream (old OutputStream based code is still here just for compatibility)

@andham
Copy link
Author

andham commented Sep 19, 2017

I've tested #95 with IBM SDK 7.1 and IBM SDK 8 in Maven 3.5.0 on Windows 7 and it seems to work with that fix. 👍

@hboutemy
Copy link
Collaborator

great, now I'll try to get Jansi team attention to merge :)

@hboutemy
Copy link
Collaborator

hboutemy commented Dec 2, 2017

#95 merged, closing the issue

@hboutemy hboutemy closed this as completed Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants