use PrintStream to avoid encoding issues #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
requested changes
Sep 20, 2017
| ps.write( data ); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think it's missing the following method:
@Override
public void write( byte[] buf, int off, int len )
{
for (int i = 0; i < len; i++)
{
write( buf[off + i] );
}
}
| OutputStream os = new FilterPrintStream(System.out); | ||
| os.write( 'A' ); | ||
| os.write( 'B' ); | ||
| os.write( '€' ); |
There was a problem hiding this comment.
This is actually an illegal method call.
Even if the parameter is an integer, the assumption is that it's a byte, so between 0 and 255.
Maybe using "€".getBytes() ? Which I've done and hit the missing method above.
|
Good finding: proposed changes incorporated |
hboutemy
added a commit
that referenced
this pull request
Dec 2, 2017
asfgit
pushed a commit
to apache/maven
that referenced
this pull request
Feb 8, 2018
asfgit
pushed a commit
to apache/maven
that referenced
this pull request
Feb 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix issue #93 this this avoids any guess on encoding and let original PrintStream do its job
test code from #88 is also committed to ease testing