Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an html ANSI output stream + bug fix. #7

Merged
merged 9 commits into from May 2, 2012

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Apr 4, 2012

Added a stream that makes HTML out of ANSI w/ tests.

Next, I think JANSI is not properly handling default text and background color (39 and 49). Those just say to keep (not set) default color, so resetting to zero is not right. The following test demonstrates the problem. It would place </span> before the red text. This pull request fixes that.

assertEquals("<span style=\"color: red;\">red</span>", colorize("�[0;31;49mred�[0m"));

@dblock
Copy link
Contributor Author

dblock commented Apr 16, 2012

Bump?

chirino added a commit that referenced this pull request May 2, 2012
Added an html ANSI output stream + bug fix.
@chirino chirino merged commit 7a23227 into fusesource:master May 2, 2012
@chirino
Copy link
Member

chirino commented May 2, 2012

Awesome! Thanks!

@dblock
Copy link
Contributor Author

dblock commented May 16, 2012

@chirino do you plan to release a new version soon? I'm speaking at Jenkins User Conf tomorrow in New York, would plug JANSI if we can release a new version of the plugin that uses it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants