Gesture migration #87
Conversation
CHANGELOG.md
Outdated
| ## Gesture | ||
| - The experimental `IGesture` interface has changed. | ||
| * The `Significance`, `Priority` and `PriotityAdjustment` have been merged into the single `GetPriority` function. | ||
| * `OnCapture` is changed to `OnCaptureChanged` and provides the previous capture state |
There was a problem hiding this comment.
Other multi-level lists use two spaces for indent, please use that in the future instead...
| if (Ended != null) | ||
| Ended(); | ||
| } | ||
| _begun = false; | ||
| _trackingKeyboard = false; |
There was a problem hiding this comment.
Should this be wrapped in a try-finally block, so we know that _trackingKeyboard becomes false even if an Ended-handler throws?
Thinking about it a bit more, events kinda feel a bit crappy for this, as one event-handler throwing is going to ruin the fun for all the others, leaving them in a limbo-state... Why does programming have to be so awful?
There was a problem hiding this comment.
I'll reorder. In general I want to call the event handlers last. I don't know if the entire handling is exception safe though, Gesture as a whole might be an issue, let me check a bit there.
There was a problem hiding this comment.
I did something minimal, but looking at the overall code I can't really "fix" it here.
| /** | ||
| The priority of the swiping gesture when competing with other gestures. | ||
|
|
||
| The default is Higher. | ||
| The default is Lower. |
There was a problem hiding this comment.
This change of behavior should be mentioned in the changelog.
This migrates several of the gesture and behaviors to use the gesture system. It allows these behaviours to overlap and behave together better.
This PR contains: